Update spiceai from EricLBuehler/candle#6
Merged
Conversation
* Add FlashMLA * Add flash attn rust ffi * Automatic computation of mla metadata * Add some shape checks * Fix .a name * Fix linking name mha_fwd_kvcache_mla * extern "C" * Handle CUDA_NVCC_FLAGS * Include flash_fwd_mla_kernel.h again * Include flash_fwd_mla_kernel.h only once * Tweak * Add flash_fwd_mla_kernel.h * Use cute::bfloat16_t * Move CUDA_NVCC_FLAGS to last * Fix reshape * Only k_c_k_pe cache, no k/v cache * Fix passing head_size_v * Remove check for "v" * Fix out shape * out-accum should be f32 * Remove references to flashattnv3 * Add test * Some fixes * Use repeat interleave * Maybe some progress... * Tests pass! * Move to excluded
* Support sdpa with mask, causal * Properly handle softcapping
…25-04-15/upstream-spiceai
ewgenius
approved these changes
Apr 15, 2025
phillipleblanc
approved these changes
Apr 15, 2025
Author
|
Failing in EricLBuehler: EricLBuehler@bca0107 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outstanding diff to ericLbuehler is EricLBuehler@fd28f08